search

AnomalyInnovations / serverless-stack-demo-client

Source for the demo app client in the Serverless Stack Guide
https://demo2.serverless-stack.com
MIT License
635 stars 204 forks source link

Replacing static file size with a dynamic lookup #32

Closed paulgalow closed 5 years ago

paulgalow commented 6 years ago

See: https://github.com/AnomalyInnovations/serverless-stack-com/pull/258

jayair commented 5 years ago

Thanks for this. As referenced https://github.com/AnomalyInnovations/serverless-stack-com/pull/258; we need to make this change in a couple of other branches here. These correspond to the various checkpoints in the guide.

I know this is a bit tedious. But let me know if you need any help with these.

paulgalow commented 5 years ago

Ah, I see! Thanks for pointing me towards those branches. I've just updated them, hope I didn't miss one. Also I've found three more branches with the relevant code snippet:

code-splitting-in-create-react-app session-test dev

Filed individual pull requests for each so you can decide which are the ones you'd like to merge. Please let me know if I need to change anything or if I have made a mistake. 🤖

jayair commented 5 years ago

Wow! Appreciate the effort. Thanks, that's perfect.

paulgalow commented 5 years ago

My pleasure. I'm glad I can contribute my tiny bit to your amazing tutorial.