Closed preshetin closed 4 years ago
Oh this is really good! Thank you for all the effort.
I can't quite merge this right away since the changes need to be made to the guide as well. But I'll merge it once we update it.
Just had a quick question about the appProps
as well. Left a comment in the code.
@jayair thank you for supporting the overall idea.
I have added the changes to the guide. It affects 20 chapters. Hopefully, there are no mean typos that would lead to errors while copying and pasting the code.
So I think it should be ready for merging.
If anything additional should be done, please let me know.
This is amazing. Thanks for editing the chapters as well. I'm going take a little bit to run through the changes and make sure they look okay.
Sure. If anything is needed, please let me know
Thanks a lot for such a great guide! learned some cool things about Serverless, AWS, DynamoDb and React.
While going through tutorial I noticed that
react-router-dom
dependency is not updated to its latest version. This pull request fixes it by updating it from 5.0 to 5.1 version.To know more about 5.1 version update, check out the maintainer's blog post.
Here are key updates related to in this pull request:
useParams
anduseHistory
hooks.Routes
component was refactored to use<Route children>
instead of<Route component>
pattern. This way feels simpler to me. Also, this way is recommended by the maintainer (see their blog post).AppliedRoute.js
, so this file was deleted.Please let me know what you think about this pull request. If all is fine, I will update the tutorial steps.
I will soon create pull requests to other branches.