Anon-Planet / thgtoa

The comprehensive guide for online anonymity and OpSec.
https://anonymousplanet.org/
Other
384 stars 41 forks source link

Fix chart being out of date/build table in Kramdown #88

Closed nopeitsnothing closed 2 years ago

nopeitsnothing commented 2 years ago

Opening a draft to fix the chart

nopeitsnothing commented 2 years ago

I don't get the "nuke references one" explain it to me like at a 5 yo plz ? you replaced [x] by [x] ? Which refers to nothing and won't work in kramdown ? it has to be [^x] ?

It's because with Kramdown it's not possible to link to anything from inside the chart. It must be done in HTML to link anywhere. So that's why I rebuilt using KD and then I linked the refs using bold citations for the reader to look for. No, it's not automatic. Yes, I don't think HTML is a good way to go for something like this. It's too hard to maintain the way it was before.

What's up with those (1:1) ? That show up in the rendered version of both tables ?

In the current guide it is shown as Partial (Only 1to1 / opt-in) and it's neater to say something like (1:1/opt-in only).

ghost commented 2 years ago

Did you https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/testing-your-github-pages-site-locally-with-jekyll ?

nopeitsnothing commented 2 years ago

I always test a local copy of the guide both manually & with the autobuild. I also build a copy of the site with Jekyll. That's done automatically with the Makefile, but I have my own Makefile that nukes the signatures because obviously I don't need to sign anything, just test the build.

ghost commented 2 years ago

well why don't you create a new repo "tests/proposals" and make a something.github.io with your version/changes so we can see the actual fully built changes ?

nopeitsnothing commented 2 years ago

well why don't you create a new repo "tests/proposals" and make a something.github.io with your version/changes so we can see the actual fully built changes ?

Too much conflict with branches, might accidentally commit a copy of the commit with my own domain instead, might mess up master. Too many issues. You can, if you want. I know it works using Jekyll and that's all I need.

nopeitsnothing commented 2 years ago

@NobodySpecial256 What do you think? Do you prefer the old buggy format or do you want to change to this one that doesn't have embedded references in the cells? Personally, I think it looks better.

nopeitsnothing commented 2 years ago

Resolved but reconsidering slightly.

nopeitsnothing commented 2 years ago

Closing as this is a stale PR and no one else has reviewed.