Closed AdamLay closed 9 months ago
Everything looks good. Haven't had a chance to test it yet. I'll try to do it today - won't be able to test with my printers for a couple weeks
@AdamLay
Only issue is DiagX and DiagY need isolate_xy in their Init method (even though they don't use it). After you add that I can merge. Thanks for this addition!
def Init(self, axis_limits, margin, isolate_xy):
Thanks @Anonoei - I've added the params as _
, not sure if this is the done thing in Python to be honest but I wanted to indicate the params are being discarded (we have no use for DiagX and DiagY on cartesian/CoreXZ - would also probably good to remove these as valid axes)
Also added quick change to amend the default axes for isolate_xy printers as well due to above reason! :) thanks
@AdamLay thanks! I merged this PR. is the correct name to indicate a variable that isn't used. It's typically used as an empty iterator, like 'for in range(0, 10)'
Not including diag_x And diag_y should be a pretty easy addition 'If self.isolate_xy:' 'self.valid_axes = ['x', 'y', 'z']' Feel free to do another PR if you want to implement that yourself
Thanks again for contributing!
When running on cartesian machines, only home the relevant axes while validating endstop variance and while running the move tests.