search

AnonymerNiklasistanonym / LatexMathifyGitHub

Render LaTeX math parts in your markdown files when viewing them on GitHub
MIT License
1 stars 0 forks source link

Support latex in github issues and comments #2

Open metasoarous opened 2 years ago

metasoarous commented 2 years ago

Thanks for making this plugin!

Is there any chance this could be extended to support rendering latex on github issues and comments? This would be especially useful for us in mathematical discussion around data science software.

Thanks again!

AnonymerNiklasistanonym commented 2 years ago

It should be possible to do so, I will check out if I can update the code to render multiple HTML nodes instead of just one (currently just the README.md).

It will take some time though since at least for me the add-on Javascript is often not being run at all by Firefox which is why I stopped using it. So I first need to find out what the bug in the implementation is but then I'll try to update the code so that all nodes with the class markdown-title/markdown-body will be rendered using KaTeX.

AnonymerNiklasistanonym commented 2 years ago

I added in the commits 900e346bbbfdf90c0cc416277442d312fb395a71 and 9840f2593915bd229ca9f086b20cd8d294e1a656 the functionality I described which means it can now even live render Markdown nodes that are Previews while editing a Markdown file or a comment. The problem still is that using Firefox sometimes the script just is not ran at all and I have no idea why, it also doesn't help that Firefox is not able to log errors like Chromium does (I updated the addon to work on Firefox and Chromium).

AnonymerNiklasistanonym commented 2 years ago

@metasoarous Do the KaTeX fonts work for you or do the rendered math areas look like math but the font looks kinda weird and not like LaTeX? I couldn't fix it for now since the new content policies - actually the font content policy of GitHub - are blocking me from loading any local or remote fonts and I have no idea if there is a safe way to extend them.

EDIT: If they don't work for you with the version you are currently using (not the updated one from today) I will update the add-on otherwise I'll check if I can somehow restore the font loading. In the meantime it would mean a lot to me if you could try the current version of the add-on (on Firefox/Chromium/whatever browser you are using) and tell me if the update broke anything for you.