search

Anonymousdog / displaycameras

System for displaying RTSP feeds from IP cameras on the Raspberry Pi
Apache License 2.0
568 stars 114 forks source link

Update mode for install script #56

Closed purpleidea closed 2 years ago

purpleidea commented 4 years ago

It should have the executable bit set so it can be run more easily.

purpleidea commented 2 years ago

This kind of patch is supported on github... You can see in the diff. Or maybe I misunderstood what you were saying?

Anonymousdog commented 2 years ago

Where do you see in GitHub, the ability to set POSIX modes on files in the repo?

On Fri, Jun 19, 2020, 9:15 AM James @.***> wrote:

It should have the executable bit set so it can be run more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/Anonymousdog/displaycameras/pull/56 Commit Summary

  • Update mode for install script

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHIYIKIVVP6LMKDYGWFNMHLRXNQHRANCNFSM4OCXAP4Q .

purpleidea commented 2 years ago

On Thu, Feb 17, 2022 at 12:45 PM Anonymousdog @.***> wrote:

Where do you see in GitHub, the ability to set POSIX modes on files in the repo?

I did it in my terminal and pushed it. I don't know how to do it in the github UI. But the Github UI can see the change and merge it. You can see that if you look closely in the github diff for the PR I sent.

HTH

On Fri, Jun 19, 2020, 9:15 AM James @.***> wrote:

It should have the executable bit set so it can be run more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/Anonymousdog/displaycameras/pull/56 Commit Summary

  • Update mode for install script

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHIYIKIVVP6LMKDYGWFNMHLRXNQHRANCNFSM4OCXAP4Q .

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

Anonymousdog commented 2 years ago

But that's relevant to almost nobody who uses the package. Only folks doing a git sync (is what it sounds like you're describing re: "see the change") to a POSIX file system would see the change. Literally everyone else would have to change the executable bit on the installer script on their local file systems, right? I don't think POSIX mode is even a supported zip file system file attribute. I don't have this repo git synced to a POSIX file system, and the whole project is EOL due to omxplayer's being deprecated. Correct me if I'm wrong about the above because, otherwise, I don't see the value.

On Thu, Feb 17, 2022, 1:38 PM James @.***> wrote:

On Thu, Feb 17, 2022 at 12:45 PM Anonymousdog @.***> wrote:

Where do you see in GitHub, the ability to set POSIX modes on files in the repo?

I did it in my terminal and pushed it. I don't know how to do it in the github UI. But the Github UI can see the change and merge it. You can see that if you look closely in the github diff for the PR I sent.

HTH

On Fri, Jun 19, 2020, 9:15 AM James @.***> wrote:

It should have the executable bit set so it can be run more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/Anonymousdog/displaycameras/pull/56 Commit Summary

  • Update mode for install script

File Changes

(0)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHIYIKIVVP6LMKDYGWFNMHLRXNQHRANCNFSM4OCXAP4Q

.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56#issuecomment-1043287470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHIYIKKGEULJT7J2PKS54TDU3U6C3ANCNFSM4OCXAP4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

purpleidea commented 2 years ago

On Thu, Feb 17, 2022 at 2:38 PM Anonymousdog @.***> wrote:

But that's relevant to almost nobody who uses the package. Only folks doing a git sync (is what it sounds like you're describing re: "see the change") to a POSIX file system would see the change. Literally everyone else would have to change the executable bit on the installer script on their local file systems, right? I don't think POSIX mode is even a supported zip file system file attribute. I don't have this repo git synced to a POSIX file system, and the whole project is EOL due to omxplayer's being deprecated. Correct me if I'm wrong about the above because, otherwise, I don't see the value.

Anyone cloning and using the package will appreciate the small change. It's small but correct. Cheers

On Thu, Feb 17, 2022, 1:38 PM James @.***> wrote:

On Thu, Feb 17, 2022 at 12:45 PM Anonymousdog @.***> wrote:

Where do you see in GitHub, the ability to set POSIX modes on files in the repo?

I did it in my terminal and pushed it. I don't know how to do it in the github UI. But the Github UI can see the change and merge it. You can see that if you look closely in the github diff for the PR I sent.

HTH

On Fri, Jun 19, 2020, 9:15 AM James @.***> wrote:

It should have the executable bit set so it can be run more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/Anonymousdog/displaycameras/pull/56 Commit Summary

  • Update mode for install script

File Changes

(0)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHIYIKIVVP6LMKDYGWFNMHLRXNQHRANCNFSM4OCXAP4Q

.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Anonymousdog/displaycameras/pull/56#issuecomment-1043287470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHIYIKKGEULJT7J2PKS54TDU3U6C3ANCNFSM4OCXAP4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>