search

Another-Game-Engine / AGE

AGE - C++11 OpenGL4 Game Engine
MIT License
49 stars 11 forks source link

IcoSphere generation integrated to RenderThread #375

Closed paulbaron closed 9 years ago

paulbaron commented 9 years ago

Icospheres integrated (not tested yet, but should work as the code is simply a copy/paste from an old commit) close #351

cesarl commented 9 years ago

You renamed "ComponentRegistrar" into "RegisterComponent" That singleton is responsible of registering component type. So it's a registrar who register stuff. Registrar in french : greffier, chef du service des inscriptions

Can you put back the old name please :)

paulbaron commented 9 years ago

In this context the name is a bit weird... but wtv ^^ I know it just a detail and we dont want to lose time on that but let's cut the pear in two (very good literal translation ;) ) and call it "ComponentRegistrationManager"? Sorry for insisting on changing the name but i've seen that few month ago and it really bother me xD

paulbaron commented 9 years ago

Ok, you might be right actually, I saw some code with classes named like that... I surrender :( cry a lot

cesarl commented 9 years ago

Hahaha ! As you want but RegisterComponent is not a good name, it's an action not a name :) If you want to rename it ComponentRegistrationManager go for it, i dont care if it express the role of the class correctly :smile:

paulbaron commented 9 years ago

/play ohyeah

EDIT: I'm disapointed by the github emojis...

cesarl commented 9 years ago

Great job ! It'll requiere future developments, but for now that really great !