search

AnotherDaphne / cosi-103a

0 stars 1 forks source link

Github actions failing to log into azure #134

Closed AnotherDaphne closed 5 months ago

AnotherDaphne commented 5 months ago

The only part of the automation for github actions that fails is the step to log into azure. The error given says:

Login failed with Error: Using auth-type: SERVICE_PRINCIPAL. Not all values are present. Ensure 'client-id' and 'tenant-id' are supplied.. Double check if the 'auth-type' is correct. Refer to https://github.com/Azure/login#readme for more information.

The auth-type used and we double checked client id and tenant id being correct. The link the error says to reference says that none of these input parameters are required to log in, but it still isn't working.

We are unsure about where to go from here.

yuh2k commented 5 months ago

Hi Daphne,

Could you please check the environment of your github repo, to see if there's something called "prd" here

image

If not please rename it to "prd" that store all keys needed.

I've tried to see if I could run using hardcoded keys on my branch, I got the error that the environment is not found from your repo.

yuh2k commented 5 months ago

Also I am tring on my end so if you may recieve multiple pipeline failed notifications, but you could mute it!

yuh2k commented 5 months ago

sGood news it's running on my branch

Successful run: https://github.com/AnotherDaphne/cosi-103a/actions/runs/8442445848

Here are things you need take care of:

  1. In my branch, I tried to hardcode those key ids to make sure thay are identical to the Azure setting: https://github.com/AnotherDaphne/cosi-103a/blob/yuh2k-ci/.github/workflows/main.yml. But it's definitely not a good practice. Just double check they are the same wtih your environment

  2. For this part: deploy-infra: needs: build runs-on: ubuntu-latest environment: prd

make sure the env name is same as your github env name

  1. Change name to resourceGroup: cosi103-a, it should be also as same as: https://portal.azure.com/?feature.msaljs=true#@brandeis.edu/resource/subscriptions/aa8cd2f3-bd4c-432d-827a-bcf15d38cbbd/resourceGroups/cosi-103a/overview

  2. You may just copy and paste my main.yaml to your main branch, just change the branches name and replace those hardcodings.

I hope it's also good on your ends