search

AnotherDole / wrongest

The Wrongest Words
3 stars 0 forks source link

Simplified room code #29

Closed AhoyLemon closed 9 years ago

AhoyLemon commented 9 years ago

We were talking about a room shortcode that was 4 characters long, case-independent.

AnotherDole commented 9 years ago

Done in the Redis branch.

I want to say that I am disappointed that the library I am using specifically prevents words like SHIT and FUCK from appearing in the ID.

Leaving this open in case you want to add another front-end component to use this.

AhoyLemon commented 9 years ago

Oh, that is disappointing! Is it overridable? Can it go completely the other direction, where it first sees if there's a swear word available and then if there's not gives you a random id?

I'm kidding. Mostly.

AhoyLemon commented 9 years ago

Okay, I'm gonna just try an option here where you can also give somebody a room code. Might take a couple of incarnations.

AhoyLemon commented 9 years ago

[f26a382] has my current idea on this.

AhoyLemon commented 9 years ago

Works great. I just need to tweak the lobby view to display both join options now (the URL as well as just the room code)

AhoyLemon commented 9 years ago

Whoops.

AhoyLemon commented 9 years ago

Okay, this one handles the pause interface as well as the create/join interface. I removed the IDs and instead made data-holds attributes that are what the IDs used to be. Populated those in sockets.js and I'm like 95% confident this is right.

That said, I want to toss it over to you for a quick sec just to verify, please close if it looks right to you.

AnotherDole commented 9 years ago

Looks right to me.