AnotherDole / wrongest

The Wrongest Words
3 stars 0 forks source link

Visual indication that a re-vote is needed #37

Closed AnotherDole closed 9 years ago

AnotherDole commented 9 years ago

If someone leaves the game during the voting phase, everyone still in the room needs to vote again Right now it just resets the voting screen for the remaining players. It might be good to be able to display a message explaining what happened.

AhoyLemon commented 9 years ago

Are you thinking something like a toast?

Pablo Neruda left the game. everyone needs to vote again.

That'll come from the bottom screen, hover for a second, and then drift out? Is that the general idea?

AnotherDole commented 9 years ago

I didn't have anything specific in mind, but a toast would work. It just need to be made clear somehow that if someone leaves during a vote, everyone re-votes.

AhoyLemon commented 9 years ago

K, I'll whip something up with a temp message. You'll probably just need to add a class to something using js at the appropriate time.

AhoyLemon commented 9 years ago

Code for later...

$('#VoteToasts').append('<li class=info>Pablo Neruda left the game. Everyone has to vote again.</a>'); clearToast('vote');
AhoyLemon commented 9 years ago

Making a better version of this.

<a onclick="makeToast('vote', 'info', 'Fucking whatever');">Make toast!</a>
AhoyLemon commented 9 years ago

Okay, so here's the new syntax for toasts...

makeToast(holder, type, msg);

This function also handles the clearing, so just makeToast with those three variables should cover you. I set one up on line 49 of sockets.js - if there's others, you're gonna have to alter 'em.

AnotherDole commented 9 years ago

Looks good except that the space where the toasts go on the room setup screen blocks out the settings.

AhoyLemon commented 9 years ago

Gotcha. Should be cool now