search

AnotherSamWilson / miceforest

Multiple Imputation with LightGBM in Python
MIT License
353 stars 31 forks source link

plot_mean_convergence subplots are numbered, not named #76

Closed gorj-tessella closed 3 months ago

gorj-tessella commented 1 year ago

Each subplot in plot_mean_convergence is labeled with the feature index, not the feature name, as of version 5.6.3. This is because the features are internally specified by the num_vars variable, which is the feature index, without converting to the feature name with self._get_var_name_from_scalar(var).

https://github.com/AnotherSamWilson/miceforest/blob/d9359a89204e3b5f10cc02e7e621a22c213e5453/miceforest/ImputedData.py#L549-L552

AnotherSamWilson commented 3 months ago

Keeping this issue open as a placeholder for adding the plot_mean_convergence function back to the package soon.

AnotherSamWilson commented 3 months ago

Fixed in fcf447ee5f6294af2c915bdd5244100cd7d4a638