Ansel-Ch / pe

0 stars 0 forks source link

Work Experience format (Work date format overly restrictive and slightly trivial) #12

Open Ansel-Ch opened 4 days ago

Ansel-Ch commented 4 days ago

As a user that might also use Linkedin and other career-related sites, I would have a profile indicating the start and end date of my internship, which I am unable to do so in the current implementation. Moreover, if the user were to have an internship that spans from Dec-2024 to Feb-2025, would they input the start year or the end year? In addition, the work experience input takes in 4 digit numbers as input rather than a date. So perhaps under the documentation, it should be referenced as internship year rather than date.

image.png [Comment 1: Should be a year rather than a date] [Comment 2: Restrictive date only accepting 4 digits]

nus-se-bot commented 1 day ago

Team's Response

We will consider implementing this bug in the future. However, it is not a bug that causes occasional inconvenience to some users since you can still use the product.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image.png Referring to both the two exceptions in the image above.

For the first case, as suggested by my reasoning earlier, winter internships and long-term jobs usually span more than a year and it would be unclear which year the user would indicate as his work experience duration

For the second case, with the ready availability of numerous Java libraries that support DateTime formatting as well as the use of these classes in the IP, it would be relatively easy to implement a DateTime rather than a trivial 4-digit number input. In case you are unaware, your current regex also allows for an input shown below.

image.png Using knowledge from the course textbook, it appears that this feature implementation showed a lack of defensive programming which is why I believe that it was a featureflaw. Hence, I believe that this should be a response.Accepted since it is in line with the exception cases provided on the course website.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/Ansel-Ch/pe/main/files/449bf2c4-cbd0-4e75-bad5-25d63ff65cbd.png) Based on the image above, still being able to use the product is not a justifiable reason to downgrade the `severity.Medium` as it is clearly stated that users can continue to use the bug with occasional inconveniences. Moreover, during testing, I noted specifically in your planned enhancements that you would solve the issue of future dates as it defies logic to record a work experience that has not happened. However, you did not account for illogical past dates and numerous strange 4-digit number combinations that could be input which are definitely plenty. (e.g 0134, 0011, 0102) The occasional inconvenience comes from the fact that work experience is usually associated with duration and only stating either a start year or end year would render this feature less useful.