Open Ansel-Ch opened 4 days ago
We will consider implementing this bug in the future. However, it is not a bug that causes occasional inconvenience to some users since you can still use the product.
Team chose [response.NotInScope
]
Reason for disagreement: Referring to both the two exceptions in the image above.
For the first case, as suggested by my reasoning earlier, winter internships and long-term jobs usually span more than a year and it would be unclear which year the user would indicate as his work experience duration
For the second case, with the ready availability of numerous Java libraries that support DateTime formatting as well as the use of these classes in the IP, it would be relatively easy to implement a DateTime rather than a trivial 4-digit number input. In case you are unaware, your current regex also allows for an input shown below.
Using knowledge from the course textbook, it appears that this feature implementation showed a lack of defensive programming which is why I believe that it was a featureflaw. Hence, I believe that this should be a response.Accepted
since it is in line with the exception cases provided on the course website.
As a user that might also use Linkedin and other career-related sites, I would have a profile indicating the start and end date of my internship, which I am unable to do so in the current implementation. Moreover, if the user were to have an internship that spans from Dec-2024 to Feb-2025, would they input the start year or the end year? In addition, the work experience input takes in 4 digit numbers as input rather than a date. So perhaps under the documentation, it should be referenced as internship year rather than date.
[Comment 1: Should be a year rather than a date] [Comment 2: Restrictive date only accepting 4 digits]