search

Ansel-Ch / pe

0 stars 0 forks source link

Find command #3

Open Ansel-Ch opened 4 days ago

Ansel-Ch commented 4 days ago

Lenient find command implementation

To Reproduce

Create several persons named "John s/o Doe" and one named "John Doe".

Expected behavior

As a user that is specifically looking for John Doe, when I used the find command, I would be met with 6 other John s/o Doe before finding John Doe. Either this find command implementation could be changed or another option would be to create an alternate find command that will be stricter on the keywords and have case sensitivity.

Severity

Medium Reference – cs2103 bug severity levels

Screenshots

image.png

Desktop

OS: Microsoft Windows Resolution: 2560 X 1440 Version: Windows 11 Home 24H2

nus-pe-bot commented 1 day ago

Team's Response

We will consider implementing stricter restrictions of the find command. However, the current find command does work as stated in the UG.

in addition, the 'find bob lee' command states that it does not return people whose name are 'bob lee' only, but returns 'bob chen' and 'catherine lee'. this shows that it accepts partial matching

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since you will be considering implementing a stricter find command in the future, this should be a response.NotInScope as it is a future enhancement.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]