search

Anselmo21 / TAB_TO_MUSICXML

A GUI developed using JavaFx that can translate guitar, bass, and drum tablatures into MusicXML files.
1 stars 1 forks source link

Incorrect HammerOn and Measures #11

Open Sayed08 opened 3 years ago

Sayed08 commented 3 years ago

Description

When a tab with 2 measures and HammerOn is converted to musicXML file, The musicXML has a wrong hammerOn and number of measures.

Bug Raised By

Sayed Mohammed

Details

Platform: Windows 10 - Eclipse IDE for Java Developers - 2020-09 version: Version 2.0 Priority: High Severity: High

Reproduction

1. Open your application 2. load the following txt file Incorrrect HammerOn and measures.txt 3. Press Convert 4. Save the MusicXML file locally 5. Use this Link https://opensheetmusicdisplay.github.io/demo/ to convert The MusicXML saved locally to Sheet music to view the error.

Results

1. Result Expected: When a tab with 2 measures is converted to musicXML file and this musicXML file when converted to sheet music should have 2 measures and a proper hammerOn. 2. Actual Result: When a tab with 2 measures is converted to musicXML file and this musicXML file, when converted to sheet music, has 4 measures and an improper hammerOn.

ScreenShots

Actual Result:

incorrect

actual

Result Expected: expected

Files

1. Incorrrect HammerOn and measures.txt 2. Incorrect HammerOn and Measures MusicXML.txt - since Github does not support uploading xml files, I uploaded the file by changing the extension to txt. 3. Correct HammerOn and Measures MusicXML.txt - since Github does not support uploading xml files, I uploaded the file by changing the extension to txt.

mohful commented 3 years ago

Hello Sayed. Thank you for your bug report! I really appreciate it! I would like to bring to your attention that i looked over the correct hammer ons and pull offs and i received this on https://www.soundslice.com/musicxml-viewer/ Maybe you would like to try again? Here is the actual image when i try to run the file you gave me. image

Sayed08 commented 3 years ago

Hey Mohammed Sorry for the confusion since Github does not support uploading xml files, I uploaded the file by changing the extension to txt. If you want I can send you the musicXML extension by email.

mohful commented 3 years ago

That would be great Sayed. You can find my email on the User manual. In order to access the manual, please read the last part of our readme file!

mohful commented 3 years ago

Hello Sayed. I can now see the error. This should be fixed by the next version of our software. I apologize for any inconvenience caused.