search

Anselmo21 / TAB_TO_MUSICXML

A GUI developed using JavaFx that can translate guitar, bass, and drum tablatures into MusicXML files.
1 stars 1 forks source link

Instrument Autodetection Fails #5

Open ahopk127 opened 3 years ago

ahopk127 commented 3 years ago

Description

Some issues are occurring with your system's instrument auto-detection facility.

Reproduction

  1. Open your application
  2. Click "Browse File" and load the file src/main/java/Capricho Arabe.txt in your repository (this file is also attached to this issue)

    Results

    Expected Result: The detected instrument is "Guitar". Actual Result: The detected instrument is "Drums".
    The parsing of this tablature also fails, see issue #4.

    Details

    Version: Master branch, commit 6028F70 (2021-03-17) Platform: Windows 10, Eclipse version 2020-12, OpenJDK 15.0.2 Priority: High Severity: High

    Screenshots

    Screenshot of Application after Parsing

    Files

    • Input Tab : Capricho Arabe.txt
    • Generated Output : generated.txt (Note: Github does not support uploading xml files, so I had to change the extension to txt)
ahopk127 commented 3 years ago

I suggest that you allow the user to manually choose the instrument (in addition to detecting it automatically) in case they experience any issue such as this one.

mohful commented 3 years ago

Hello ahopk127. Thank you for your suggestion! I will be sure to discuss this with my team! I believe there was some sort of miscommunication, which i would like to clear. Our system does not support full tablatures like Capricho Arabe or War Pigs. Our system does not support Drums as well. I apologize for any inconvenience. We haven't implemented a way such that we can ignore or parse the stuff that is not part of a normal tablature like repeats.