Ansersion / myRtspClient

A RTSP client based on jrtplib
Apache License 2.0
160 stars 91 forks source link

SDP_FMTP_H264_PATTERN enhancement request #32

Open fguerzoni opened 4 years ago

fguerzoni commented 4 years ago

Hi, I found an ip camera that doesn't verify the regex SDP_FMTP_H264_PATTERN in sdp_data.cpp

This (from a different camera) works: "fmtp:96 packetization-mode=1;profile-level-id=64001E;sprop-parameter-sets=Z2QAHqwrUFAX/Kg=,aO48MA=="

But this from my new ip camera doesn't work: "fmtp:96 profile-level-id=4D401E;packetization-mode=0;sprop-parameter-sets=Z01AHpWgKAv+WbAQ,aO48gA==;config=00000001674d401e95a0280bfe59b0100000000168ee3c800000000106f02c1645cdee00110667ebad2bed54aaa0524e66e229ca86a9f5b918bc766a6690a60bca273da4d6ffffffffff7380"

The issue is caused by 'profile-level-id' which is put before packetization-mode

So please replace the current regex: fmtp:(.+) +packetization-mode=([0-2]);.sprop-parameter-sets=([A-Za-z0-9+/=]+),([A-Za-z0-9+/=]+) with the following: fmtp:(.+).+packetization-mode=([0-2]);.sprop-parameter-sets=([A-Za-z0-9+/=]+),([A-Za-z0-9+/=]+) (I placed a dot before +packetization-mode)

thanks and regards f

Ansersion commented 4 years ago

Thanks for your feedback.