AnshSinghSonkhia / 40Pie-Music-Player-Website

40π Music Player -- Using HTML5, CSS3 & JavaScript
https://anshsinghsonkhia.github.io/40Pie-Music-Player-Website
MIT License
20 stars 37 forks source link

Added repeat functionality #12

Open Cursed-Ninja opened 1 year ago

Cursed-Ninja commented 1 year ago

Resolved #11

Working loop button

AnshSinghSonkhia commented 1 year ago

Hey @Cursed-Ninja, Kindly attach some screenshots of your final working website.

So, that I could merge your PR.

Cursed-Ninja commented 1 year ago

I'm sending link of screen recorded video https://drive.google.com/file/d/10HVIFw1rh_XUh6Tfp_M5i_qoeO0Xz7K-/view?usp=sharing.

Kindly have a look.

AnshSinghSonkhia commented 1 year ago

What happens when one clicks the repeat button? I can't understand this. Neither this is clear in the video.

Cursed-Ninja commented 1 year ago

During the initial part of video when the repeat button is grey, the repeat is off. But then I click on it and it turns white, then the same song will repeat until I change the song manually by choosing another or clicking on next or previous or turn off the repeat button (back to grey as shown at the end of video).

Cursed-Ninja commented 1 year ago

I can make the repeat button to be darker when inactive so that it is clear when it's on and when it's off. @AnshSinghSonkhia Do tell me if you want anything else to be changed.

Cursed-Ninja commented 1 year ago

@AnshSinghSonkhia Kindly ping me if you get any merge conflicts while trying to merge the branch.

AnshSinghSonkhia commented 1 year ago

Hey @Cursed-Ninja , Kindly comment some screenshots and videos of the working...

Cursed-Ninja commented 1 year ago

Repeat off -

image

Repeat on -

image

The repeat functionality works like this -

On pressing the repeat button, repeat turns on (indicated by brightening of loop button). The current song once finishes will repeat over again and again until the repeat button is turned off. Once the repeat button is turned off (indicated by dimming of loop button), the next song would start playing once the current song finishes.

https://drive.google.com/file/d/1QxzccfbAbKzIP2qhLHZ5vGJ1WAlwTTzy/view?usp=sharing

In this video, during the first half the repeat button is on as it is bright, and the song repeats itself. Once the repeat button is turned off, the song stops repeating and the next song starts playing once the current song finishes.