search

AnsibleCheck / ansiblecheck

One Stop Solution For Checking Your Ansible Roles and Playbooks
MIT License
55 stars 6 forks source link

Add debian 9 (stretch) documentation + build fixes #23

Closed lcaflc closed 6 years ago

lcaflc commented 7 years ago

Add documentation informations about debian 9 (stretch) version of the images.

Please also note that the debian-9 tag is missing in the automated builds produced on docker hub.

Thanks.

ChristopherDavenport commented 7 years ago

Hmmm. I think this may be because the Dockerfile still needs a little work to get correct. Seems bdist_wheel is blocking a complete build.

Here is the failing build that matters to getting the tag added.

lcaflc commented 7 years ago

Hi, yes I just see that yesterday night when tests failed. I've started to figure out the issue and it seems related to an outdated setuptools version. Will upate PR If I find the fix.

lcaflc commented 7 years ago

It's now failing because systemd binary is not installed by default in base docker image. In fact I don't really understand why you try to run the systemd init in the check instead of something a little simplier like /bin/true. Or run ansible itself to check that it work inside the build container.

Thanks.

lcaflc commented 7 years ago

dockercloud check still fail, but I don't have access to status page to check why.

Thanks.

lcaflc commented 6 years ago

See issue #28, nothing related to this addition.

Thanks.

ChristopherDavenport commented 6 years ago

Does this require a modification to the Docker Hub build script for stretch, not a big deal to implement. Just checking if this was updating or fully new functionality.

lcaflc commented 6 years ago

I don't see your hub build configuration so I don't know if it needs updating. However cf: https://hub.docker.com/r/ansiblecheck/ansiblecheck/builds/ I see that a build is trigerred for debian-stretch tag, but not for debian-9 so certainly missing some part.

ChristopherDavenport commented 6 years ago

Should build, as I just triggered the new tag. 👍