AnsibleShipyard / ansible-zookeeper

Ansible playbook for ZooKeeper
MIT License
95 stars 114 forks source link

tarball folder (/opt/src) is hardcoded and thus not configurable #35

Closed lhoss closed 8 years ago

lhoss commented 8 years ago

we don't use /opt (instead another special subdir in /usr/local), so we need this to be configurable.

I already fixed this locally and ready to make a PR (after https://github.com/AnsibleShipyard/ansible-zookeeper/pull/34 got merged)

ernestas-poskus commented 8 years ago

Why it's not configurable ? In Ansible you can override default variables

lhoss commented 8 years ago

but this path (/opt/src) is not yet a role variable, see tarball.yml

ernestas-poskus commented 8 years ago

@lhoss yes you are right, then I suggest to extract it into variable leave default as it is and you will be able to change it to satisfy your needs

lhoss commented 8 years ago

that's how I've implemented it (will create PR latest tomorrow, after #34 merge), adding new variable:

zookeeper_tarball_dir: /opt/src
ernestas-poskus commented 8 years ago

@lhoss again thank you for contribution, your PR's merged into 0.11.0 release

lhoss commented 8 years ago

happy to contribute ! keeping up the improvements, just created https://github.com/AnsibleShipyard/ansible-zookeeper/pull/38

lhoss commented 8 years ago

you can close https://github.com/AnsibleShipyard/ansible-zookeeper/pull/38 fixed this

ernestas-poskus commented 8 years ago

issue resolved