Open lhoss opened 7 years ago
ok for you todo in the same PR ?
if they are related then ok
Finally we would like to apply more cleanups in the role (sep. PR!), especially renaming those vars without zookeeper_ prefix.
sounds good, this bothered me for a long time
I'ld propose to add an info block in the README incl. howto map from
info info README will be enough, in release I will mention breaking changes and notice to update as well.
sounds good, this bothered me for a long time
👍
if they are related then ok
they are related in the sense that currently some common things (like dirs-init and optional env-vars) aren't present for all the deployment modes
Oh and finally (sep. PR) should try to unwrangle slightly diff. tasks around zoo.cfg and myid. ps: Do you have a clue why the 'myid' file is/was different between tarball (orig. only used for centos/redhat) and Debian(deb) version.. maybe distro specific(packaging) ? :
Debian.yml
template: src=myid.j2 dest={{zookeeper_conf_dir}}/conf/myid force="{{ zookeeper_force_myid }}"
tarball.yml
template: src=myid.j2 dest={{data_dir}}/myid owner=zookeeper group=zookeeper force="{{ zookeeper_force_myid }}"
Before doing all the cleanups, I've now revived the movitation to complete my test PR https://github.com/AnsibleShipyard/ansible-zookeeper/issues/60
Do you have a clue why the 'myid' file is/was different between tarball (orig. only used for centos/redhat) and Debian(deb) version.. maybe distro specific(packaging) ?
might be related to packaging
Just found out on a deployment on Ubuntu 16.04 I will def. provide a PR fix ASAP, by extracting the working task (from tarball.yml) out into
common-config.yml
Actually I'ld like todo the same with (not too old) task/feature (also in tarball):
@ernestas-poskus ok for you todo in the same PR ?
ps: Finally we would like to apply more cleanups in the role (sep. PR!), especially renaming those vars without
zookeeper_
prefix. Again the question howto best keep downward compatibility (after renaming). I'ld propose to add an info block in the README incl. howto map from new->old vars (rather than add an automatic mapping in the default vars)