AnsibleShipyard / ansible-zookeeper

Ansible playbook for ZooKeeper
MIT License
95 stars 114 forks source link

Remove 'z' from untar command #68

Closed dzeban closed 7 years ago

dzeban commented 7 years ago

The latest Zookeeper version 3.5.3-beta is distributed as plain tar archive, so tar zxf fails with gzip: stdin: not in gzip format.

Also, recent versions of tar recognize format by itself, so there is no need in 'z' option.

dzeban commented 7 years ago

@ernestas-poskus I've found unarchive module in Ansible for unpacking that we can use instead of command: tar xf. Should I remake this PR with unarchive instead of removing z option?

ernestas-poskus commented 7 years ago

I've found unarchive module in Ansible for unpacking that we can use instead of command: tar xf. Should I remake this PR with unarchive instead of removing z option?

No, not necessary. There were problems with unarchive module at least before Ansible 2.0 as far as I remember.