AnsonYeung / vscode-pascal-language-basics

Pascal Language Basics Extension
MIT License
5 stars 3 forks source link

Does not work with Omnipascal #7

Open thevikke opened 1 year ago

thevikke commented 1 year ago

Hello, any idea why this extension does not work with Omnipascal extension?

  1. Enable Omnipascal.
  2. Enable Pascal Language Basics.
  3. Syntax highlighting doesn't work.
  4. Disable Omnipascal.
  5. Syntax highlighting works.

Thank you!

AnsonYeung commented 1 year ago

Unfortunately I'm no longer maintaining this actively. For troubleshooting I recommend checking whether choosing the language manually in vscode GUI works.

thevikke commented 1 year ago

Okay, seems it is because I'm using Objectpascal and this extension doens't seem to work on that. :(

thevikke commented 1 year ago

Could we just add objectpascal to package.json? Then this extension would also work with Object Pascal or do you know easier way? I can fork, if you don't want to do anything. ☮️

"languages": [
            {
                "id": "pascal",
                "aliases": [
                    "Pascal",
                    "pascal"
                ],
                "extensions": [
                    ".pas",
                    ".pp"
                ],
                "configuration": "./language-configuration.json"
            }
AnsonYeung commented 1 year ago

What do I need to modify, if you do it in a pull request I can merge and push a new version after looking at your changes.

AnsonYeung commented 1 year ago

Also I am not sure whether the highlighting will work properly or conflict with the one provided by the extension (as I haven't worked on this for a long time). Preferably you should also see whether my extension highlight your code correctly first.