search

Ansuel / tch-nginx-gui

Modified file to apply to a stock technicolor GUI
GNU General Public License v3.0
341 stars 52 forks source link

Duplicate src declaration 18.x macoers #1037

Open lorenzocanalelc opened 3 years ago

lorenzocanalelc commented 3 years ago

Device Model/Firmware: Every ARM 18.x that previously added macoers repo. GUI Version: 9.6.65

Because in the official page https://www.macoers.com/blog/antonio-macolino/repository_openwrt_homeware_18_brcm63xx_tch it is suggested to add the repo in the file /etc/opkg/customfeeds.conf when the GUI add them in the opkg.conf file they are duplicated and the error 

 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_base_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/base). Skipping.
 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_packages_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/packages). Skipping.
 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_luci_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/luci). Skipping.
 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_routing_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/routing). Skipping.
 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_telephony_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/telephony). Skipping.
 * opkg_conf_parse_file: Duplicate src declaration (chaos_calmer_core_macoers https://www.macoers.com/repository/homeware/18/brcm63xx-tch/VANTW/target/packages). Skipping.

Appears

Dark4Codrutz commented 3 years ago

you have those already in opkg.conf for the Ansuel GUI ! https://github.com/Ansuel/tch-nginx-gui/commit/5d48b3a90e0d6a860284ddd401e6066224fbda2f If subsequently you follow that guide and add them to customfeeds.conf without removing them from opkg.conf than you are intentionally duplicating them and opkg command tells you just that. I fail to see where the Issue is .

lorenzocanalelc commented 3 years ago

The problem is that the check for the feeds already present is done by the GUI only in the opkg.conf file (Here specifically: https://github.com/Ansuel/tch-nginx-gui/blob/c4cdffba215b7f8cd600fa1ddd62b1bd79a743a9/decompressed/gui_file/etc/modgui_scripts/02_specific.sh#L74) , so either make the check to actually check also the customfeeds.conf file or make the GUI add the Macoers repo in the customfeeds.conf instead of the opkg.conf as it is suggested by the owner of the repo