search

Ansuel / tch-nginx-gui

Modified file to apply to a stock technicolor GUI
GNU General Public License v3.0
344 stars 52 forks source link

Port forwarding on/off switch works only when editing the rule #1084

Open ferrarimarco opened 3 years ago

ferrarimarco commented 3 years ago

NB: Before submitting an issue, check if there is one already open that suits the problem you are having! -> done, no related issues.

Device Model/Firmware: DGA4130, AGTEF_2.2.1 GUI Version: 9.6.65-89342d7b

Please go to Cards >> GUI Settings >> Debug Report and press the Generate button. Attach the debug file here: N/A (will do later, if needed).

Description of problem, HOW TO REPRODUCE, Media/Photos:

The ON/OFF switch for forwarding rules doesn't respond to clicks. After a quick inspection with Chrome Dev Tools, it appears to not have any onClick event listeners. Clicking on the switch has no effects.

To reproduce:

  1. Create a port forwarding rule.
  2. Save the port forwarding rule, which is turned on by default.
  3. Click on the on/off switch to turn the rule off.

Thanks for your support!

ferrarimarco commented 3 years ago

After a quick test, it appears to work ONLY while editing a rule, not from the modal that lists all the rules.

I suppose that this may confuse the users, because the switch appears to be clickable even from the modal that lists all the rules.

Suggestion: completely disable the onClick "nature" of the switch in the forwarding rules table?