search

Ansuel / tch-nginx-gui

Modified file to apply to a stock technicolor GUI
GNU General Public License v3.0
344 stars 52 forks source link

Style Fix - Horizontal scrolling shown when not needed #117

Closed FrancYescO closed 6 years ago

FrancYescO commented 6 years ago

Are these css style really needed ?

https://github.com/Ansuel/tch-nginx-gui/search?q=max-width%3A880px%3Boverflow-x%3Aauto&unscoped_q=max-width%3A880px%3Boverflow-x%3Aauto

they cause glitch in the UI like this: https://i.imgur.com/O06bE3j.png

kevdagoat commented 6 years ago

That’s not really a glitch

Sent from my iPhone

On 27 Aug 2018, at 8:48 pm, Francesco M notifications@github.com wrote:

Are these css style really needed ?

https://github.com/Ansuel/tch-nginx-gui/search?q=max-width%3A880px%3Boverflow-x%3Aauto&unscoped_q=max-width%3A880px%3Boverflow-x%3Aauto

they cause glitch in the UI like this: https://i.imgur.com/O06bE3j.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

FrancYescO commented 6 years ago

@kevdagoat and what is it? why the horizontal scrollbar is here? is pretty useless :\

kevdagoat commented 6 years ago

It’s due to your browsers window size.

On 28 Aug 2018, at 3:37 pm, Francesco M notifications@github.com wrote:

@kevdagoat and what is it? why the horizontal scrollbar is here? is pretty useless :\

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

FrancYescO commented 6 years ago

the browser window is a lot larger than the modal, as you can see in the upper part of screenshot the Ping part that havn't the DIV with max-width value is shown correctly ... so why the same criteria is not used in tracert for example?