Ansuel / tch-nginx-gui

Modified file to apply to a stock technicolor GUI
GNU General Public License v3.0
346 stars 52 forks source link

QoS tile interface non-functional #172

Closed 0jay closed 5 years ago

0jay commented 6 years ago

Device Model: TG799vac Gui Version: 8.7.2 / 8.7.60

Description of problem: QoS tile interface unable to apply changes (invalid instance)

How to reproduce (if possible): Trivial

Media/Photos (if possible):

kevdagoat commented 6 years ago

If you are on firmware version 17.2, it has been removed. Please revert back to 16.3.

On 12 Sep 2018, at 8:12 am, Oscar James notifications@github.com wrote:

NB: Before submitting an issue, check if there is one already open that suits the problem you are having!

Device Model: TG799vac Gui Version:

Description of problem: QoS tile interface unable to apply changes (invalid instance)

How to reproduce (if possible):

Media/Photos (if possible):

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

0jay commented 6 years ago

You’re saying QoS is removed in 17.2?

The QoS tile reports it as active (correctly listing the number of rules). If the code’s been removed then ideally it should not display at all in 17.2

kevdagoat commented 6 years ago

Yep

On 12 Sep 2018, at 11:07 am, Oscar James notifications@github.com wrote:

You’re saying QoS is removed in 17.2?

The QoS tile reports it as active (correctly listing the number of rules). If the code’s been removed then ideally it should not display at all in 17.2

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

BreakSecurity commented 6 years ago

You’re saying QoS is removed in 17.2?

The QoS tile reports it as active (correctly listing the number of rules). If the code’s been removed then ideally it should not display at all in 17.2

I agree it should not display at all in 17.2

kevdagoat commented 6 years ago

I think it is related to the switch config in /etc/config/network There are a few lines that say option qos(something) ‘0’ option vlan ‘0’

If you change them to one it may work.

On Mon, 17 Sep 2018 at 6:58 pm, BreakSecurity notifications@github.com wrote:

You’re saying QoS is removed in 17.2?

The QoS tile reports it as active (correctly listing the number of rules). If the code’s been removed then ideally it should not display at all in 17.2

I agree it should not display at all in 17.2

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Ansuel/tch-nginx-gui/issues/172#issuecomment-421968092, or mute the thread https://github.com/notifications/unsubscribe-auth/AoHR_jfGFmWQv96i7EXJWw8KEnlF1Gp7ks5ub4A7gaJpZM4Wkbjw .

-- Kind regards, Kelvin Hands

0jay commented 6 years ago

Mate there are so many things in this gui that are broken, I’d love to chip in but neither have the skills nor the time.

Hoping Luci will work out otherwise I’ll just try to get a better grip on cl

2018-09-17 11:01:51 +0000 Kevdagoat notifications@github.com :

I think it is related to the switch config in /etc/config/network There are a few lines that say option qos(something) ‘0’ option vlan ‘0’

If you change them to one it may work.

On Mon, 17 Sep 2018 at 6:58 pm, BreakSecurity notifications@github.com wrote:

You’re saying QoS is removed in 17.2?

The QoS tile reports it as active (correctly listing the number of rules). If the code’s been removed then ideally it should not display at all in 17.2

I agree it should not display at all in 17.2

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/Ansuel/tch-nginx-gui/issues/172#issuecomment-421968092 https://github.com/Ansuel/tch-nginx-gui/issues/172#issuecomment-421968092 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AoHR_jfGFmWQv96i7EXJWw8KEnlF1Gp7ks5ub4A7gaJpZM4Wkbjw https://github.com/notifications/unsubscribe-auth/AoHR_jfGFmWQv96i7EXJWw8KEnlF1Gp7ks5ub4A7gaJpZM4Wkbjw

.

-- Kind regards, Kelvin Hands

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ansuel/tch-nginx-gui/issues/172#issuecomment-421969168, or mute the thread https://github.com/notifications/unsubscribe-auth/AoSCUYVsCM-YsMDNKsn71f814pOl4h5Xks5ub4EfgaJpZM4Wkbjw .

BreakSecurity commented 6 years ago

It should be removed if detected 17.2

kevdagoat commented 6 years ago

Will have a look sometime this weekend. All of my modems are running 16.3 so will have to flash

BreakSecurity commented 6 years ago

Have you made any progress on this?

kevdagoat commented 6 years ago

Both my modems are in use atm I cannot afford to take down my network to flash 17.2

On 21 Oct 2018, at 10:47 am, BreakSecurity notifications@github.com wrote:

Have you made any progress on this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Ansuel commented 6 years ago

actually can someone describe this problem?

we need to first check if /etc/config/qos exist...

Also it's strange that in 17.2 qos got disabled :/

0jay commented 6 years ago

the qos tile displays in 17.2 on the tg799 yet is non functional.

Ansuel commented 6 years ago

does the gui gives any error?

0jay commented 6 years ago

invalid instance

Ansuel commented 6 years ago

post here content of qos pls (not the file i have problem with direct file)

0jay commented 6 years ago
config label 'dscp_Zero'                                                        
        option dscp '0'                                                         

config label 'Normal'                                                           
        option trafficid '1'                                                    

config label 'User'                                                             
        option trafficid '3'                                                    

config label 'Video'                                                            
        option trafficid '4'                                                    

config label 'DNS'                                                              
        option trafficid '5'                                                    

config label 'Management'                                                       
        option trafficid '6'                                                    

config label 'DHCP'                                                             
        option trafficid '7'                                                    

config label 'Voice'                                                            
        option trafficid '8'                                                    

config label 'PPP'                                                              
        option trafficid '9'                                                    

config class 'W_Q0'                                                             
        option priority '0'                                                     
        option weight '5'                                                       

config class 'W_Q1'                                                             
        list trafficid '2'                                                      
        option priority '0'                                                     
        option weight '5'                                                       

config class 'W_Q2'                                                             
        list trafficid '3'                                                      
        list trafficid '4'                                                      
        option priority '0'                                                     
        option weight '10'                                                      

config class 'W_Q3'                                                             
        list trafficid '5'                                                       
        option priority '0'                                                     
        option weight '20'                                                      

config class 'W_Q4'                                                             
        list trafficid '6'                                                      
        option priority '0'                                                     
        option weight '40'                                                      

config class 'W_Q5'                                                             
        list trafficid '7'                                                      
        option priority '1'                                                     
        option weight '40'                                                      

config class 'W_Q6'                                                             
        list trafficid '8'                                                      
        option priority '1'                                                     
        option weight '40'                                                      

config class 'W_Q7'                                                             
        list trafficid '9'                                                      
        option priority '1'                                                     
        option weight '40'                                                      

config class 'L_Q0'                                                             
        option priority '0'                                                     

config class 'L_Q1'                                                             
        list trafficid '4'                                                      
        option priority '1'                                                     

config class 'L_Q2'                                                             
        list trafficid '5'                                                      
        list trafficid '6'                                                      
        list trafficid '7'                                                      
        option priority '2'                                                     

config class 'L_Q3'                                                             
        list trafficid '8'                                                      
        option priority '3'                                                     

config class 'WMM_BK_Q0'                                                        
        option priority '0'                                                     

config class 'WMM_BK_Q1'                                                         
        option priority '1'                                                     

config class 'WMM_BE_Q0'                                                        
        option priority '2'                                                     

config class 'WMM_BE_Q1'                                                        
        option priority '3'                                                     

config class 'WMM_VI_Q0'                                                        
        list trafficid '4'                                                      
        option priority '4'                                                     

config class 'WMM_VI_Q1'                                                        
        list trafficid '5'                                                      
        option priority '5'                                                     

config class 'WMM_VO_Q0'                                                        
        list trafficid '6'                                                      
        list trafficid '7'                                                      
        option priority '6'                                                     

config class 'WMM_VO_Q1'                                                        
        list trafficid '8'                                                      
        option priority '7'                                                     

config classgroup 'TO_WAN'                                                      
        option classes 'W_Q0 W_Q1 W_Q2 W_Q3 W_Q4 W_Q5 W_Q6 W_Q7'                
        option default 'W_Q0'                                                   
        option policy 'wfq'                                                     

config classgroup 'TO_LAN'                                                      
        option classes 'L_Q0 L_Q1 L_Q2 L_Q3'                                    
        option default 'L_Q0'                                                   
        option policy 'sp'                                                      

config classgroup 'TO_WLAN'                                                     
        option classes 'WMM_BE_Q0 WMM_BK_Q0 WMM_BK_Q1 WMM_BE_Q1 WMM_VI_Q0 WMM_VI
        option default 'WMM_BE_Q0'                                              
        option policy 'sp'                                                      

config device 'atm_8_35'                                                        
        option classgroup 'TO_WAN'                                              

config device 'ptm0'                                                            
        option classgroup 'TO_WAN'                                              

config device 'eth4'                                                            
        option classgroup 'TO_WAN'                                              

config device 'eth0'                                                            
        option classgroup 'TO_LAN'                                              

config device 'eth1'                                                            
        option classgroup 'TO_LAN'                                              

config device 'eth2'                                                            
        option classgroup 'TO_LAN'                                              

config device 'eth3'                                                            
        option classgroup 'TO_LAN'                                              

config device 'wl0'                                                             
        option classgroup 'TO_WLAN'                                             

config device 'wl1'                                                             
        option classgroup 'TO_WLAN'                                             

config reclassify                                                               
        option target 'dscp_Zero'                                               
        list srcif 'lan'                                                        
        list srcif 'Guest1'                                                     
        list srcif 'Guest1_5GHz'                                                
        list srcif 'fonopen'                                                    
        list dstif 'wan'                                                        
        list dstif 'wan6'                                                       

config reclassify                                                               
        option target 'dscp_Zero'                                               
        list dscp '!EF'                                                         
        list dstif 'wan'                                                        
        list dstif 'wan6'                                                       

config classify                                                                 
        option target 'User'                                                    
        option proto 'tcp'                                                      
        option dstports '25,80,109,110,143,220,587,993,995,1723,1935,3074,3658,8

config classify                                                                 
        option target 'User'                                                    
        option proto 'tcp'                                                      
        list srcif 'lan'                                                        
        list srcif 'Guest1'                                                     
        list srcif 'Guest1_5GHz'                                                
        option dstports '443'                                                   

config classify                                                                 
        option target 'User'                                                    
        option proto 'ah'                                                       

config classify                                                                 
        option target 'User'                                                    
        option proto 'udp'                                                      
        option dstports '123'                                                   

config classify                                                                 
        option target 'Video'                                                   
        option proto 'tcp'                                                      
        option dstports '554'                                                   

config classify                                                                 
        option target 'Video'                                                   
        option proto 'igmp'                                                     

config classify                                                                 
        option target 'DNS'                                                     
        option dstports '53'                                                    
        option proto 'tcp'                                                      

config classify                                                                 
        option target 'DNS'                                                     
        option dstports '53'                                                    
        option proto 'udp'                                                      

config classify                                                                 
        option target 'Management'                                              
        option proto 'icmp'                                                     

config classify                                                                 
        option target 'Management'                                              
        option proto 'gre'                                                      

config classify                                                                 
        option target 'Management'                                              
        option proto 'esp'                                                      

config classify                                                                 
        option target 'Management'                                              
        option proto 'udp'                                                      
        option dstports '7547,51007,500,4500'                                   

config classify                                                                 
        option target 'Management'                                              
        option dstports '7547,51007'                                            
        option proto 'tcp'                                                      

config classify                                                                 
        option target 'Management'                                              
        option dstports '443'                                                   
        list srcif 'loopback'                                                   
        option proto 'tcp'                                                      

config classify                                                                 
        option target 'DHCP'                                                    
        option proto 'udp'                                                      
        option dstports '67,68,546,547'                                         

config classify                                                                 
        option target 'Voice'                                                   
        option dstports '2195'                                                  
        option proto 'tcp'                                                      

config classify                                                                 
        option target 'Voice'                                                   
        list srcif 'loopback'                                                   
        list dscp 'EF'
0jay commented 6 years ago

bank was updated from 16.3 originally

Ansuel commented 6 years ago

can you tell me in the modal what device you see port status lan and port status wlan?

0jay commented 6 years ago

sorry Ansuel, tch-nginx-gui no longer runs on my modem.

I updated to one of the new stables which broke my static ip config and would not allow changes to reconfigure it so I tried to downgrade to the previous stable and nginx was broken by the downgrade.

I am now running luci

Ansuel commented 6 years ago

if you want to restore you need to do 3-4 command as nginx broke cause of luci

0jay commented 6 years ago

I didn’t install luci until i had no interface when nginx broke.

FrancYescO commented 5 years ago

can we consider this as solved?

flywire commented 5 years ago

Telstra TG799vac GUI Version [ 8.9.52 ] 2018 Software Version 17.2.0261-7021006-20180717060049-820-RA

QoS, Queue, QoS Queue Scheduling on Interface WAN, change Enabled to on, Saved changes - No errors. Changed and saved a few other dropdowns.

0jay commented 5 years ago

remove the qos modal (or allow removal) from 17.2 firmwares would be a solution.

On Tue, 6 Nov 2018 at 5:47 am, Francesco M notifications@github.com wrote:

can we consider this as solved?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ansuel/tch-nginx-gui/issues/172#issuecomment-435988874, or mute the thread https://github.com/notifications/unsubscribe-auth/AoSCUQRDuZurXyndd-8Btur7Nhr79qxKks5usIe-gaJpZM4Wkbjw .

flywire commented 5 years ago

I consider it works on 17.2.

0jay commented 5 years ago

Ok if it’s working then close. I was under the impression qos was removed from the 17.2 firmware.