Fix eval flexbert - Githubissues

NohTow commented 1 week ago

Changes

When trying to launch the eval for arch ablations, they failed due to different issues. First, eval_metrics parameter was not added to FlexBert models, only to MosaicBert. Second, I had a ValueError: sampler option is mutually exclusive with shuffle so I removed the shuffle parameters from the different jobs.

Tests

[ ] Is the new feature tested? (Not always necessary for all changes -- just adding to the checklist to keep track)
[ ] Have you ran all the tests?
[ ] Do the tests all pass?
[ ] If not, have you included an explanation of which tests this PR breaks and/or why (below this checklist)

I did not runs the tests, but managed to run the evaluations with these fixes.

jackcook commented 1 week ago

Is this branch up to date? I made these same changes in #60 and I think they might already be in main

NohTow commented 1 week ago

Actually, this has been solved in #60. I did not pull on this machine sorry.

Edit: yes @jackcook sorry, my bad.

jackcook commented 1 week ago

No worries! Was just worried I made a weird merge or something

AnswerDotAI / bert24

Fix eval flexbert #69