AnswerDotAI / rerankers

A lightweight, low-dependency, unified API to use all common reranking and cross-encoder models.
Apache License 2.0
784 stars 40 forks source link

Add generic document type #3

Closed Anmol6 closed 4 months ago

bclavie commented 4 months ago

Hey, so sorry it took me so long to get around to this PR.

I like the overall idea and I think we should move towards this model!

My three comments are:

I might take a stab at this myself later this afternoon, but thanks again for your contribution, and so sorry for the how long it took me to review this1

bclavie commented 4 months ago

Hey, I've made a number of changes. There was a lot of API breaking change, which is something that will never happen with rerankers (I'm intending to keep everything compatible with the release version for as long as humanly possible). The key result of my updates are basically:

I think this is ready to merge now, thank you for getting this started!