search

Answers4AWS / graffiti-monkey

Goes around tagging things
Apache License 2.0
255 stars 88 forks source link

Config file versus command line arguments #14

Closed paulwakeford closed 8 years ago

paulwakeford commented 9 years ago

Currently if options are specified in both the config file and as command line arguments, the config file 'wins'. I think this is the wrong way around and am proposing reversing this order.

By reversing the logic, my standard options would be in the config file, and if I want to override those options (my defaults) I use a command line argument.

This has become more of an issue now I've added support for items such as the boto profile and volume ids as command line arguments. e.g. I want my 'test' profile to be the default so I put that in the config file, but if I want to target my production account I have to edit the config file - it would be easier if I could use the command line --profile argument to override.

Thoughts on changing the primary option source to be the command line argument?

Thanks,

Paul

pvbouwel commented 9 years ago

To me it indeed makes sense to give preference to command line passed arguments. +1

pas256 commented 9 years ago

I agree too. Is there a PR for this?

paulwakeford commented 9 years ago

Nope, I was just shooting the breeze, testing the waters.