search

Answers4AWS / graffiti-monkey

Goes around tagging things
Apache License 2.0
255 stars 88 forks source link

Provide the possibility to configure which tags to propagate using a yaml file #7

Closed pvbouwel closed 9 years ago

pvbouwel commented 10 years ago

Hi,

These commits add some testing on calling the application and where primarily used to make sure that I don't change any behavior from the application. In order to made it easier testable I refactored cli.py a little bit so that mocking would be more easy. Other than that the first commit doesn't implement real changes. The 2nd commit adds the possibility to take a configuration file to define the tags that are to be propagated. This allows people to use graffiti-monkey for any tags they wish.

Kind regards,

Peter

pas256 commented 9 years ago

Wow, thanks Peter. I will review this soon (but probably after re:invent).

pvbouwel commented 9 years ago

There is no hurry, currently I am using my fork to check up on tags a few times a day and to propagate them when necessary, so I am not blocked.

Thank you for creating this nice monkey.

On Wed, Nov 5, 2014 at 5:52 PM, Peter Sankauskas notifications@github.com wrote:

Wow, thanks Peter. I will review this soon (but probably after re:invent).

— Reply to this email directly or view it on GitHub https://github.com/Answers4AWS/graffiti-monkey/pull/7#issuecomment-61840834 .

StubbsPKS commented 9 years ago

Just curious as to whether these changes have been implemented into version 0.7.0. The source seems to include a yml configuration file ( at conf/graffiti_monkey.yml), but I used pip to install graffiti monkey. Do I need to remove graffiti monkey with pip, change the configuration file and then build from source or can I create this configuration file somewhere that my pip-installed version can use it?

pvbouwel commented 9 years ago

Hi StubbsPKS,

No this is not yet implemented in graffiti-monkey, it still needs to be pulled in. It is working (I alread use it myself). I did however notice thanks to your post that the Travis build was failing since my requirements.txt was not correclty. Now I see as well that it fails due too missing boto credentials. Tests on my setup run fine but tests shouldn't depend on presence of credentials so I'll look into it.

pvbouwel commented 9 years ago

Build is fixed again.

pas256 commented 9 years ago

Thank you very much @pvbouwel, particularly for getting the test passing again.

Merged.

pvbouwel commented 9 years ago

You're welcome. I was surprised I'd broken them :-). On Dec 16, 2014 6:13 AM, "Peter Sankauskas" notifications@github.com wrote:

Thank you very much @pvbouwel https://github.com/pvbouwel, particularly for getting the test passing again.

Merged.

— Reply to this email directly or view it on GitHub https://github.com/Answers4AWS/graffiti-monkey/pull/7#issuecomment-67113509 .