Ant-Shell / rancid-tomatillos

Movie Viewing App!!!

rancid-tomatillos-ivory.vercel.app

0 stars 1 forks source link

Refactor for env file usage #42

Closed Ant-Shell closed 2 years ago

Ant-Shell commented 2 years ago

What does this PR do?

[] New feature (adds functionality)
[x] Debugging/Refactor

Implementation/Changes:

Add cypress environment variables in intercepts
Slight refactoring of un-necessary code
Remove un-needed data/fixture file

Where should your reviewer start?

.gitignore

What (if any) features are you implementing?

Cypress env variable usage

What (if anything) did you refactor?

cypress/e2e/all-movie.cy.js
cypress/e2e/individual-movie.cy.js

What issues does this PR close?

N/A

Is there anything that you need from your teammate?

Code review :)

Any other comments, questions, or concerns?

Please let me know if anything needs clarification

How Has This Been Tested?

[x] I tested my changes in the browser
[x] I tested with Cypress

Checklist:

[x] My code follows the style guidelines of this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[x] My changes generate no new bugs
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes