Closed JosephMillsAtWork closed 1 year ago
More digging shows that it is not the save of the file but the
Config.INSTANCE
that is not getting updated when changing the values
Config.INSTANCE.updateToPreset();
is what is causing this. It is updating to defaults in the call. Conifig,INSTANCE just gets reset at this point.
Config.save()
After changing the preset all is fine and it saves correctly. We need a better way to disable the presets if the user changes the settings. (change to Custom or something of the sort)
Yeah, can do - quickest way would be to serialize the config to bytes - and compare to the INSTANCE bytes, and if there's a mismatch, assume there's a change, set the preset to Custom and then let it continue with it's logic
Should just be a couple of lines tops
Or if we could just disable the tabs somehow if preset is not custom
Probably more intuitive to have it update to custom. If they change properties, it's pretty much a given they want custom options
I consider this to be closed. But that said lets add something. I mean I helped write the mod and didn't get the preset deal.
Branch develop-1.19-crossplatform Platform Forge
When testing a mixin for icebergs on the new platforms. I noticed that the icebergs did not generate even though I set to true. Something is not saving the data nor changing the values even for runtime. I am not sure if this effects fabric.