Some unknown values shouldn't raise a KeyError

Antar1011 / Onix

The Pokemon Data-Mining Package

http://onix.readthedocs.io/en/latest/

GNU General Public License v3.0

7 stars 0 forks source link

Some unknown values shouldn't raise a KeyError #67

Closed Antar1011 closed 8 years ago

Antar1011 commented 8 years ago

Consult with PS about which unknown values in logs just get ignored (e.g. unknown natures get processed as Hardy/Serious, IIRC) and ignore them rather than raising an error.

Antar1011 commented 8 years ago

So the potential issues appear to be:

invalid natures (get parsed to be neutral)
null values for things like happiness (should be okay as-is)
missing keys (I saw a missing "ability" key but Onix should be robust to any being missing)

Antar1011 commented 8 years ago

In progress on the bugfixes branch