AntaresSimulatorTeam / Antares_Simulator

Antares-Simulator is an Open Source power system simulator to quantify the adequacy or the economic performance of interconnected energy systems, at short or remote time horizons.
https://antares-simulator.org
Other
58 stars 24 forks source link

Use `Simulation::ITimeSeriesNumbersWriter` for all modes (load, wind, solar, thermal, renewable, NTC) #1322

Closed flomnes closed 1 month ago

flomnes commented 1 year ago

See src/solver/simulation/timeseries-numbers.cpp

Also, don't pass time_series_writer to function StoreTimeSeriesNumbersIntoOuput if possible (@JasonMarechal25 mentions dependency injection)

flomnes commented 1 year ago

https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/1219#discussion_r1205396793

flomnes commented 1 year ago

The problem is that Simulation::ITimeSeriesNumbersWriter is not as generic as it seems.

It's write function looks like this

class ITimeSeriesNumbersWriter {
public:
    virtual ~ITimeSeriesNumbersWriter() = default;
    virtual void write(const Data::BindingConstraintsList& list) = 0;
};

If we wanted to write other types of TS numbers, we'd need some kind of genericity on the contrary.

pet-mit commented 1 month ago

ANT-2170