Antelope-Valley-College / polr

GNU General Public License v2.0
24 stars 10 forks source link

Upgrade overall experience #10

Closed technowhizz closed 1 year ago

technowhizz commented 1 year ago

I'm not sure if this is the best way to achieve this, but it works.

Looking further into #9 I found that the useCurrent() function was returning 0000-00-00 00:00:00 instead of CURRENT_TIMESTAMP. The same with useCurrentOnUpdate(). This should hopefully avert this.

Open to other ideas as to why this might be happening but in the meantime this should work

technowhizz commented 1 year ago

The changes are intended to improve the usability and functionality of the codebase.

Environment Configuration

mwilmes-at-avc commented 1 year ago

@technowhizz This patch looks great; thank you for your efforts. I have one question about database/migrations/2023_01_24_234401_add_secrets_key_default.php. The code in my repository uses Schema modification commands to remain DB agnostic. I would like to allow for other DBs to be used with POLR in the future. The update I'm seeing is an ALTER statement that only works for MySQL. I don't have much experience with Laravel; this upgrade was a knee-jerk to get to PHP 8. Do you see any technical reason that we could not keep the declarative syntax using Schema?

technowhizz commented 1 year ago

Will open new PR