Closed technowhizz closed 1 year ago
The changes are intended to improve the usability and functionality of the codebase.
Added env.php
to bootstrap/app.php
Modified LinkHelper.php
to add adf.ly
to the list of shortener domains
Modified LinkController.php
to enable a redirect notice if enabled in the environment
Modified add_link_table_indexes.php
to order links by ID when chunking them
Modified CSS for site URL field and check button in index page
Added input validation script for link URL field in index page
Updated login page with message from environment, if enabled
@technowhizz This patch looks great; thank you for your efforts. I have one question about database/migrations/2023_01_24_234401_add_secrets_key_default.php. The code in my repository uses Schema modification commands to remain DB agnostic. I would like to allow for other DBs to be used with POLR in the future. The update I'm seeing is an ALTER statement that only works for MySQL. I don't have much experience with Laravel; this upgrade was a knee-jerk to get to PHP 8. Do you see any technical reason that we could not keep the declarative syntax using Schema?
Will open new PR
I'm not sure if this is the best way to achieve this, but it works.
Looking further into #9 I found that the
useCurrent()
function was returning0000-00-00 00:00:00
instead ofCURRENT_TIMESTAMP
. The same withuseCurrentOnUpdate()
. This should hopefully avert this.Open to other ideas as to why this might be happening but in the meantime this should work