search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 17 forks source link

nodeos in docker will now accept external connections #132

Closed mikelik closed 1 year ago

mikelik commented 1 year ago

Previously nodeos was only accessible from the docker container. Now it will be also possible to connect to it from host machine (but still not from the external machines).

It works like this: from nodeos perspective ports are exposed to the world (so listening on 0.0.0.0 inside of the container). But docker itself limits exposing ports to localhost. This way you can connect from host to the container. But you cannot connect from external world to the host.

ScottBailey commented 1 year ago

I believe we use the description field to update our release notes, so we really should have a description field even for a small change like this.

ScottBailey commented 1 year ago

Bootstrap test issue resolved on my end. :-) But it looks like tests/test_nodes.py is impacted by this change and needs an update.

ScottBailey commented 1 year ago

Bootstrap test issue resolved on my end. :-) But it looks like tests/test_nodes.py is impacted by this change and needs an update.

Resolved by changing test process, will write issue to document.