Closed mikelik closed 1 year ago
This LGTM, but testing on a fresh Win11 install didn't work.
If we are fixing the netfx
issue, is it appropriate to fix this argcomplete
issue here as well?
If we are fixing the
netfx
issue, is it appropriate to fix thisargcomplete
issue here as well?
Good catch, thanks.
It wasn't as straight forward as I thought it would be, but I have added pip install
to installation script of antelopeio-dune.
I had to change python
to python311
, because during testing only the latter was adding python.exe
to the PATH.
So now to test this PR you need to run ./generate_chocolatey.bat
and later new steps from README.md:
Run PowerShell as administrator and go to the directory where your *.nupkg was downloaded.
Run following commands:
choco uninstall antelopeio-dune -y
choco install netfx-4.8 python311 docker-desktop -y
Now restart PowerShell as administrator again (so that python command could be executed) and run:
choco install .\antelopeio-dune.1.1.0.nupkg -y
Restart your computer (this is because %PATH% has to be reloaded. In cmd.exe it is enough to run command refreshenv).
Open PowerShell / cmd.exe and try that following command works: dune.bat --version.
Now automatic package verification is passing: https://community.chocolatey.org/packages/antelopeio-dune/1.1.0
I'm not sure where this issue should be actually fixed - either on Chocolatey CI Package Verification side or in Docker Desktop Chocolatey package (Docker Desktop requires .NET). Anyway I'm adding the temporary solution to our package.