search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 20 forks source link

DUNE binary name conflicts with ocaml-dune on Linux #141

Closed mikelik closed 1 year ago

mikelik commented 1 year ago

As a user I would like to have an easy way of installing and using DUNE.

Currently our DUNE's main binary name is named dune. Unfortunately on Ubuntu by default there is already preinstalled ocaml-dune with the same binary name.

Currently when installing .deb or .rpm package we are adding antelopeio-dune binary to /usr/bin because of this conflict. If user wants to use our DUNE he has to modify the $PATH manually.

ScottBailey commented 1 year ago

oacml-dune exists for OSX as well.

ScottBailey commented 1 year ago

Also, all caps naming feels unfriendly for Linux.

ScottBailey commented 1 year ago

These names have been suggested:

kj4ezj commented 1 year ago

I asked ChatGPT for some new names for DUNE. Most names were corny, a bit on the nose, or otherwise sucked. It suggested "AnteCoat", and I figured if you dropped "ante" and just used "coat" then it could be a pretty cool name. It invokes the idea of the coat of an Antelope, or just a coat you wear. You could even make a backronym if you really wanna stay on-brand, like "Container Orchestration for Antelope Tooling".

stephenpdeos commented 1 year ago

I know we've gravitated away from x-eos, but how about Docker Utility for Node Extension Operating Suite (DUNEOS)?

mikelik commented 1 year ago

From @larryk85: dunes

For the dune rename, I am currently leaning towards "dunes" it's still a valid word, it's short, it still is an environment for Antelope just plural. And the acronym can become Docker Utilities for Node Execution and Subsystems

stephenpdeos commented 1 year ago

Decision: will update name to DUNES

stephenpdeos commented 1 year ago

Scope:

Out of scope:

Open questions

@nsjames this change is coming and we will likely need a complimentary issue for DevRel. Any questions?

jolly-fellow commented 1 year ago

It seems documents like this https://github.com/eosnetworkfoundation/docs/blob/main/docs/20_smart-contracts/10_getting-started/10_dune-guide.md in other repositories should be updated too.

jolly-fellow commented 1 year ago

I have created a branch and a pull request there as we agreed: https://github.com/AntelopeIO/DUNE/pull/165 Please take a look. I'm not sure about names of the installation packages and names of directories and symlinks creating during the installation process, should they be changed, does it make sense to create the symlinks? And may be the tags and names in the GitHub and Docker repositories should be changed too?

ScottBailey commented 1 year ago

Out of scope:

  • [ ] Source code

Open questions

  • [ ] What about chocolatey?

I think we should revisit the issue of updating the source and file names. A global search and replace is probably easier now than it will ever be.

For example, my first review step could be ensuring that both the following commands return empty:

find | rg -i dune | rg -iv dunes
rg -i dune | rg -iv dunes

I think doing it all at once, reviewing it all at once, and TESTING it all at once instead of drawing it out might be a better approach.

jolly-fellow commented 1 year ago

It was agreed by the team in comments to https://github.com/AntelopeIO/DUNE/pull/165 to rename everything at one time.

ScottBailey commented 1 year ago

@jolly-fellow sorry, my grep wasn't as good as it should have been, this is better:

find | rg -i dune  | rg -i dune[^s]
rg -i dune  | rg -i dune[^s]