Rename DUNE to DUNES

[jolly-fellow]

Renames all names DUNE to DUNES corresponding to the issue: https://github.com/AntelopeIO/DUNE/issues/141

I'm not sure about names of the installation packages and names of directories and symlinks creating during the installation process, should they be changed, does it make sense to create the symlinks? And may be the tags and names in the GitHub and Docker repositories should be changed too?

[jolly-fellow]

I would rename all dune to dunes. Otherwise we will be confused where we should use which version.

I agree but when we discussed this issue on the meeting and I asked this question about the code I got answer that the source code is out of the scope of this issue so I didn't change it.

Can you rename all instances of antelopeio-dune to dunes? antelopeio-dune was package name chosen because dune was taken.

I can everything I just not sure that it should be changed everywhere. May be there is another agreement for names of the packages. In the package building scripts antelopeio-dune is creating from a prefix variable and a name variable. Where a prefix is "antelopeio" I was sure that it is an important part of the package name. If you are sure it may be removed and a package may be called dunes.deb I will remove it or you may remove it yourself. I have created this branch for the collaborative work.

[jolly-fellow]

@mikelik I will finish soon the total renaming as you wish. Please check the packaging scripts please to make sure that I corrected the building of the package names right. And thanks for the list.

[jolly-fellow]

I think we should revisit the issue of updating the source and files. A global search and replace is probably easier now than it will ever be.

For example, my first review step could be ensuring that both the following commands return empty:

find | rg -i dune | rg -iv dunes
rg -i dune | rg -iv dunes

I think doing it all at once, reviewing it all at once, and TESTING it all at once instead of drawing it out might be a better approach.

I agree but I asked about the source code on the meeting and got explicit answer don't change it. But well I will change the sourcecode in the last commit. It will be possible to roll it back.

[jolly-fellow]

By the way what we will do with name of the repository?

[mikelik]

By the way what we will do with name of the repository?

Bucky will rename it just after we merge the PR.

Thanks for doing all the changes, I think it's the right approach.

[jolly-fellow]

By the way what we will do with name of the repository?

Bucky will rename it just after we merge the PR.

Thanks for doing all the changes, I think it's the right approach.

So should I change the URLs now or after it will be changed?

[mikelik]

I would do it now and we can coordinate with Bucky

[jolly-fellow]

I would do it now and we can coordinate with Bucky

And when official Docker image appearing in the repository? Its name should be changed too.

[mikelik]

And when official Docker image appearing in the repository? Its name should be changed too.

Yes, this can be done just after merging as well. New package dunes will have to be created here: https://github.com/orgs/AntelopeIO/packages/container/package/

[jolly-fellow]

Well I hope I have finished. Renamed all what I found, fixed couple of errors and reformatted some code to follow PEP8.

[jolly-fellow]

This looks great with just a couple really minor exceptions.

Thanks for your help. I can't understand how I left these strings not renamed. :)

[jolly-fellow]

Please remove plugins/dunes_hellp/main.py. It seems like it was maybe accidentally added during testing.

Tests pass for me now. +1

Please address the packaging issue.

removed