search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 17 forks source link

Cannot bootstrap an image with `--cdt=3.0.1` #192

Closed ScottBailey closed 1 year ago

ScottBailey commented 1 year ago

Bootstrap ignores version directive and tries to build with latest CDT (version 4.0.0).

See #191 for a possible fix.

ScottBailey commented 1 year ago

I am considering what we can do for testing. This is a regression and so it seems especially sensible to ensure it doesn't happen in future by adding a regression test. The downside of this is that any test we do here could be lengthy.

Here's an idea for the steps:

  1. remove any currently running version_test containers and images.
  2. Modify bootstrap.sh to take a custom tag (--tag=) and tag the image with ONLY that tag. DO NOT tag with latest, version, or git commit hash when tag exists
  3. Call bootstrap.sh with the older CDT version (3.0.1) and the tag (e.g. --cdt=3.0.1 --tag=version_test)
  4. Start a version_test container
  5. Test the container uses cdt version X.

This will take awhile to run, so we may want it disabled by default?

ScottBailey commented 1 year ago

This may be a reasonable command to get the version. docker run --name dunes_version_test -it dunes:latest /usr/bin/ls /usr/opt/cdt