search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 20 forks source link

Allow dunes to operate on arbitrarily named containers. #213

Open ScottBailey opened 1 year ago

ScottBailey commented 1 year ago

Currently, dunes only works with a container named dunes_contatiner. It would be nice to have CLI option to indicate the name of the container we want to operate on. Additionally, an option to set the image on start would be nice.

It would be okay if the container name option is -C, --container-name. And image name (only for --start-container) is --image-name.

It would be nice to do this:

dunes -C my_test_dunes --start-container --image-name dunes:1.2.0
dunes -C my_test_dunes --list
dunes --container-name my_test_dunes --stop-container

Additionally to do in this issue is evaluate all tests marked destructive and make them NON destructive by using a test container.

ScottBailey commented 1 year ago

We will NOT want to modify tests/a100_generate_container_image_test.py since it tests the release functionality of bootstrap.py.

Note that bootstrap.py already takes --tag to safely generate an image with an arbitrary tag.

ScottBailey commented 1 year ago

Much of the work is already done. This seems to be where the container and image name are set.

But we do need to evaluate this code to ensure that we download the correct image. Or no image at all.