search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 20 forks source link

Make the dirtydb fix backwards compatible. #225

Closed ScottBailey closed 1 year ago

ScottBailey commented 1 year ago

172 allows for clearing a dirty DB; unfortunately we failed to consider backwards compatibility in the update.

Fixed by swapping the $4 and $5 arguments in the script and updating the caller inside dunes.

This allows an older DUNE executable to call a newer DUNES container image and vice versa.

Will close #226

ScottBailey commented 1 year ago

I have following error:

Thanks! I'll look into this.

ScottBailey commented 1 year ago

@mikelik Did you test with an existing DUNES image, bootstrap a new one, or use an old DUNE image?

If you used an existing DUNES image, it would fail like this.

ScottBailey commented 1 year ago

@mikelik after further investigation, I am unable to recreate the error you had.

Does a full test work? i.e. pytest --run-all tests/ Or, simpler: pytest --run-all tests/test_nodes.py

It does in ci/cd...

mikelik commented 1 year ago

@mikelik Did you test with an existing DUNES image, bootstrap a new one, or use an old DUNE image?

If you used an existing DUNES image, it would fail like this.

Yes, I have used old image from v1.1.0. I misunderstood the requirements, I thought new scripts should work with old Docker image because of the description:

This allows an older DUNE executable to call a newer DUNES container image and vice versa.

In that case, I'm fine with the change. Can you please update the description in the PR and in the issue?