search

AntelopeIO / DUNES

Docker Utilities for Node Execution
Other
26 stars 17 forks source link

Fix failing test_project.py - merge to main #87

Closed mikelik closed 1 year ago

mikelik commented 1 year ago

Stop container before removing TEST_APP_DIR to release the open file handles. This way removing TEST_APP_DIR is completed before starting another test.

jolly-fellow commented 1 year ago

I don't understand why "Fix failing test_project.py" rewrites ALL files which takes to the functional tests? It destroys history of changes and doesn't allow to see what was really changed. Please leave only actual changes in the PR.

mikelik commented 1 year ago

I don't understand why "Fix failing test_project.py" rewrites ALL files which takes to the functional tests? It destroys history of changes and doesn't allow to see what was really changed. Please leave only actual changes in the PR.

This PR is based on https://github.com/AntelopeIO/DUNE/pull/79. I hoped PR79 would be already merged to main so in this PR only my changes would remain. I have created a PR with fixes to functional-test branch here: https://github.com/AntelopeIO/DUNE/pull/88.