AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
113 stars 69 forks source link

scripts/install_deps.sh no longer exists in 4.0 branch #1172

Closed matthewdarwin closed 1 year ago

matthewdarwin commented 1 year ago

When leap 4.0 was released, It had a scripts/install_deps.sh. When I was building a recent patch, I noticed the script is no longer there.

Ideally the build instructions don't change within a release cycle. They can change at major releases of course.

I have (since the pre nodeos 1.0 days) my own custom build script which generates an apt package for our infrasructure. It looks like below: $TAG is filled in from our build system, which is whatever tag/branch I want to build. $TEMPDIR is a temporary directory where the build runs.

#!/bin/sh

set -e

lib=$(cat lib)
export HOME=$TEMPDIR/builder
echo "LIB = ${lib}"
echo "HOME = ${HOME}"

mkdir -p $TEMPDIR/repo/usr/bin
mkdir -p $TEMPDIR/repo/etc/nodeos
mkdir -p $TEMPDIR/repo/usr/share/bash-completion/completions
#cp -pra *.diff $TEMPDIR

cd $TEMPDIR
git clone --depth 1 -b $TAG https://github.com/AntelopeIO/leap.git --recursive
cd leap
git submodule update --init --recursive
mkdir build
scripts/install_deps.sh
time scripts/pinned_build.sh /local/lib/${lib} $TEMPDIR/leap/build 30
cd ..
leap/build/bin/nodeos --print-default-config > $TEMPDIR/repo/etc/nodeos/config.ini.example
cp leap/build/bin/* $TEMPDIR/repo/usr/bin/
cp leap/build/programs/cleos/bash-completion/completions/cleos $TEMPDIR/repo/usr/share/bash-completion/completions/cleos
cp leap/build/programs/leap-util/bash-completion/completions/leap-util $TEMPDIR/repo/usr/share/bash-completion/completions/leap-util
matthewdarwin commented 1 year ago

FWIW, the final layout of the build looks like this:

  /etc/systemd_monitor/nodeos
  /etc/nodeos/snapshot_version
  /etc/nodeos/config.ini.example
  /DEBIAN/control
  /DEBIAN/postinst
  /DEBIAN/conffiles
  /DEBIAN/prerm
  /lib/systemd/system/nodeos.service
  /usr/bin/cleos
  /usr/bin/nodeos
  /usr/bin/leap-util
  /usr/bin/trace_api_util
  /usr/bin/keosd
  /usr/share/bash-completion/completions/cleos
  /usr/share/bash-completion/completions/leap-util
bhazzard commented 1 year ago

We need to back this out for 4.0.1 so as not to have a breaking change (a missing script) in a patch release.

heifner commented 1 year ago

Removed via https://github.com/AntelopeIO/leap/pull/857

arhag commented 1 year ago

We agreed to just revert #857.