search

AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
116 stars 68 forks source link

EOS VM OC: add a compile knob to define the transition threshold for transitioning from mirroring to mprotect() #1256

Closed linh2931 closed 1 year ago

spoonincode commented 1 year ago

I'm no longer sure this is the right/best approach. Especially after your collection of data for EVM memory usage behavior.

I think maybe, instead, for now, the main-thread memory (currently used for anything other then ROtrx threads) should be constructed with something like a 16MB threshold (or possibly even left at 33MB, I haven't done the math), and then the ROtrx thread memory be something much lower.. even 128 or 256KB. This way we still get absolute maximum performance for EVM trxs in blocks.

So in other words, maybe it shouldn't be a compile time knob but something passed in the ctor based on the thread usage criteria as above.

linh2931 commented 1 year ago

Close this. We use https://github.com/AntelopeIO/leap/issues/645 to track OC memory related work.