search

AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
116 stars 68 forks source link

Support C++20 for release branch #1497

Closed yarkinwho closed 9 months ago

yarkinwho commented 1 year ago

Contracts such as EOS-EVM rely on testers code in leap to build the unit tests. It would cause quite a lot trouble if the leap code does not support C++20 while some other libraries used by the unit tests start to switch to C++20.

heifner commented 1 year ago

For 4.0.x, I believe all that is needed is the removal of these lines: https://github.com/AntelopeIO/leap/pull/1070/files#diff-d81bca537ada1ccf67b84dc409d9a71010c9dfb14006b57c45adf09717bbbc9bL40-L44

Consider backporting this fix to release/4.0.

spoonincode commented 9 months ago

As of 5.0 libtester is C++20. A change to the EVM testing environment to use libtester 5.0 is at eosnetworkfoundation/eos-evm-contract#681 so I think we can close this issue out as complete.