search

AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
113 stars 69 forks source link

leap-4.0.5: non-informative "Connection refused" message for p2p connections #1974

Open cc32d9 opened 6 months ago

cc32d9 commented 6 months ago

4.0.5 and earlier Leap versions.

If a p2p neighbor host exists, but refuses a connection, nodeos logs an error that is difficult to troubleshoot:

error 2023-12-10T20:18:48.407 net-1     net_plugin.cpp:2360           operator()           ] connection failed to 0.0.0.0:0 Connection refused

The error message needs to provide the host and port information.

bhazzard commented 6 months ago

@heifner this looks like it would be a simple enhancement to include in 6.0.0. Do you agree it doesn't need backporting?

heifner commented 6 months ago

I believe this is fixed in 5.0. In 5.0 it uses the provided peer address instead. As to if this should be pack-ported to 4.0.x, seems like it should as it is a bug fix.