search

AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
116 stars 70 forks source link

invalid_type_inside_abi exception #2079

Open heifner opened 8 months ago

heifner commented 8 months ago

The invalid_type_inside_abi is defined as 

      FC_DECLARE_DERIVED_EXCEPTION( invalid_type_inside_abi,           abi_exception,
                                    3015004, "The type defined in the ABI is invalid" ) // Not to be confused with abi_type_exception

Note the comment Not to be confused with abi_type_exception. Looks like it has been confused. It should be used only when validating the ABI. I believe these uses in abi_serializer::_variant_to_binary are incorrect. The exception there should be abi_type_exception. https://github.com/AntelopeIO/leap/blob/d2af8636c116a66d530af34bc3565f73b7ed29eb/libraries/chain/abi_serializer.cpp#L595-L595 https://github.com/AntelopeIO/leap/blob/d2af8636c116a66d530af34bc3565f73b7ed29eb/libraries/chain/abi_serializer.cpp#L575-L575 https://github.com/AntelopeIO/leap/blob/d2af8636c116a66d530af34bc3565f73b7ed29eb/libraries/chain/abi_serializer.cpp#L356-L356

bhazzard commented 8 months ago

This can comfortably slide into 6.0.0 instead of 5.x if necessary... fit into 5.0.1 opportunistically.