search

AntelopeIO / leap

C++ implementation of the Antelope protocol
Other
113 stars 69 forks source link

IF: Test Failure: nodeos_startup_catchup_if_lr_test #2351

Closed heifner closed 2 months ago

heifner commented 3 months ago

AssertionError: Expected to at least receive 9.0 transactions per block, but only getting 7.6

It is not clear what is going on here. Could just mean our ci/cd could not keep up. Or maybe all the voting is slowing it down enough it can't process trxs quick enough. Would be worth looking closer at the logs. Might need more net threads to allow trx processing along with vote processing. We should consider processing votes in its own thread pool so they can't clog the net thread pool.

Happened at the same time: https://github.com/AntelopeIO/leap/actions/runs/8467659168/job/23199344820 ubsan https://github.com/AntelopeIO/leap/actions/runs/8467659168/job/23199345763 ubnuntu22repo

heifner commented 3 months ago

https://github.com/AntelopeIO/leap/actions/runs/8467659168/job/23202047049 ubsan https://github.com/AntelopeIO/leap/actions/runs/8470250491/job/23208031573 ubsan https://github.com/AntelopeIO/leap/actions/runs/8470775216/job/23209763881 ubsan https://github.com/AntelopeIO/leap/actions/runs/8473570201/job/23218612943 ubsan https://github.com/AntelopeIO/leap/actions/runs/8473560007/job/23218575881 ubsan https://github.com/AntelopeIO/leap/actions/runs/8474150133/job/23220336271 ubsan https://github.com/AntelopeIO/leap/actions/runs/8483888997/job/23246072871 ubuntu20 https://github.com/AntelopeIO/leap/actions/runs/8485757221/job/23251313946 ubuntu20 https://github.com/AntelopeIO/leap/actions/runs/8485757221/job/23251314584 asserton https://github.com/AntelopeIO/leap/actions/runs/8485924791/job/23251825122 ubuntu20 https://github.com/AntelopeIO/leap/actions/runs/8487440267/job/23255470442 ubuntu22 https://github.com/AntelopeIO/leap/actions/runs/8486208479/job/23252467364 ubsan https://github.com/AntelopeIO/leap/actions/runs/8515732035/job/23323970155 ubuntu22

greg7mdp commented 2 months ago

Issue was caused by the addition of two new tests in https://github.com/AntelopeIO/leap/pull/2335.

Two workflow runs with these tests removed passed without problems. https://github.com/AntelopeIO/leap/actions/runs/8523025337

Resolution:

@spoonincode will beef up the instances the workflows are run on for: NP, LR, ubsan, asan, asserton I have created issue https://github.com/AntelopeIO/leap/issues/2369 to track this task.