Revisit use of is_on_main_thread - Githubissues

AntelopeIO / leap

C++ implementation of the Antelope protocol

Other

116 stars 68 forks source link

Revisit use of is_on_main_thread #930

Closed linh2931 closed 1 year ago

linh2931 commented 1 year ago

https://github.com/AntelopeIO/leap/pull/776 assumed read-only transactions to only run on read-only threads. https://github.com/AntelopeIO/leap/pull/901 changed that and read-only transactions can run on main thread too. Uses of is_on_main_thread() in the code base need to be revisited to make sure they still work as expected.

Timing summary for read-only transactions assumes when running on main thread, read-only-threads is not configured.
EOS-VM-OC cache entries eviction and update assume read-only trxs do not run on main thread.

linh2931 commented 1 year ago

Opened https://github.com/AntelopeIO/leap/issues/950 and https://github.com/AntelopeIO/leap/issues/951 for better tracking.

Close this.